This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
fix append empty role bug #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Victor Drobny <[email protected]>
igor-egorov
reviewed
Aug 15, 2018
| @@ -396,7 +396,7 @@ namespace iroha { | |||
| SELECT CASE | |||
| WHEN EXISTS (SELECT * FROM inserted) THEN 0 | |||
| %s | |||
| ELSE 5 | |||
| ELSE 4 | |||
There was a problem hiding this comment.
It is absolutely unclear what are the magic numbers used :(
Even more - neither executor itself nor its methods do not have documentation.
There was a problem hiding this comment.
Error codes concept is still in development as I understand, so this is internal API.
igor-egorov
suggested changes
Aug 15, 2018
| TEST_F(AppendRole, ValidAppendRoleTestWhenEmptyPerms) { | ||
| addAllPerms(); | ||
| ASSERT_TRUE(val(execute(buildCommand(TestTransactionBuilder().createRole( | ||
| "role2", {})), |
There was a problem hiding this comment.
Please do a const variable for "role2" string.
Signed-off-by: Victor Drobny <[email protected]>
igor-egorov
approved these changes
Aug 15, 2018
lebdron
approved these changes
Aug 15, 2018
| @@ -396,7 +396,7 @@ namespace iroha { | |||
| SELECT CASE | |||
| WHEN EXISTS (SELECT * FROM inserted) THEN 0 | |||
| %s | |||
| ELSE 5 | |||
| ELSE 4 | |||
There was a problem hiding this comment.
Error codes concept is still in development as I understand, so this is internal API.
Signed-off-by: Victor Drobny <[email protected]>
|
SonarQube analysis reported 1 issue
|
bakhtin
pushed a commit
that referenced
this pull request
Nov 2, 2018
* fix append empty role bug Signed-off-by: Victor Drobny <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Victor Drobny [email protected]
Description of the Change
It was impossible to add a role without permissions to account. Now it is possible.
Benefits
One small bug was fixed.